Skip to content

[release-1.8] fix(techdocs): use correct type for additionalAllowedUriProtocols#4399

Merged
openshift-merge-bot[bot] merged 1 commit intoredhat-developer:release-1.8from
karthikjeeyar:rhdh-patch/techdocs-release-1.8
Mar 13, 2026
Merged

[release-1.8] fix(techdocs): use correct type for additionalAllowedUriProtocols#4399
openshift-merge-bot[bot] merged 1 commit intoredhat-developer:release-1.8from
karthikjeeyar:rhdh-patch/techdocs-release-1.8

Conversation

@karthikjeeyar
Copy link
Member

@karthikjeeyar karthikjeeyar commented Mar 12, 2026

Description

The code for allowined additional uri protocols in techdocs clearly expects a string[] but the schema specifies string, this change brings the schema in line with the code

Consuming code

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@karthikjeeyar karthikjeeyar changed the title patch(techdocs): use correct type for additionalAllowedUriProtocols fix(techdocs): use correct type for additionalAllowedUriProtocols Mar 12, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Mar 12, 2026

Image was built and published successfully. It is available at:

@karthikjeeyar
Copy link
Member Author

karthikjeeyar commented Mar 12, 2026

Verified this PR image quay.io/rhdh-community/rhdh:pr-4399-40ac582a with following config in rhdh-local, RHDH application boots up without any schema errors.

techdocs:
    builder: local
    generator:
      runIn: local
    publisher:
      type: local
    sanitizer:
      additionalAllowedURIProtocols: 
       - vscode
image image

@karthikjeeyar karthikjeeyar changed the title fix(techdocs): use correct type for additionalAllowedUriProtocols [release-1.9] fix(techdocs): use correct type for additionalAllowedUriProtocols Mar 13, 2026
@karthikjeeyar karthikjeeyar changed the title [release-1.9] fix(techdocs): use correct type for additionalAllowedUriProtocols [release-1.8] fix(techdocs): use correct type for additionalAllowedUriProtocols Mar 13, 2026
kim-tsao
kim-tsao approved these changes Mar 13, 2026
View reviewed changes
Copy link
Member

@kim-tsao kim-tsao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 13, 2026
@openshift-merge-bot openshift-merge-bot bot merged commit 08326e8 into redhat-developer:release-1.8 Mar 13, 2026
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kim-tsao kim-tsao kim-tsao approved these changes

@christoph-jerolimov christoph-jerolimov Awaiting requested review from christoph-jerolimov

@JessicaJHee JessicaJHee Awaiting requested review from JessicaJHee

Assignees

@kim-tsao kim-tsao

Labels

lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@karthikjeeyar @kim-tsao